Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use throughput in result instead of requests #35

Open
hekike opened this issue Nov 6, 2017 · 0 comments
Open

Use throughput in result instead of requests #35

hekike opened this issue Nov 6, 2017 · 0 comments

Comments

@hekike
Copy link
Contributor

hekike commented Nov 6, 2017 •
edited

Hi,

I'm not sure that I miss something or is it a bug:

autocannon-compare determinates the winner based on the throughput.
See: https://github.com/mcollina/autocannon-compare/blob/9ba26c51775ba33986873087ccd69786fd635359/compare.js#L19

Shouldn't benchmarks use throughput for the diff calculation and in the result object instead of requests?
See:

benchmarks/lib/autocannon.js

Line 50 in 0f51ac4

} else if (comp.aWins) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hekike