Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Benchmark Result #302

Open
2 tasks done
shayff opened this issue Jul 22, 2023 · 3 comments
Open
2 tasks done

Consistent Benchmark Result #302

shayff opened this issue Jul 22, 2023 · 3 comments

Comments

@shayff
Copy link

shayff commented Jul 22, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

Hey,
I'm trying to do some performance improvement research and therefore I tried to run the benchmark for Fastify a few times and I got a bit different result.

For example:

  • First run I got total of 1,066,024 requests
  • Second run I got total of 1,344,495 requests

A difference of approximately 20% without any changes.
How can I get more consistent result?

@Eomm
Copy link
Member

Eomm commented Jul 23, 2023

How can I get more consistent result?

You need a controlled environment.
If the test PC starts something (a calendar notification or a new connection to something) impacts a running bench.

For this reason the benchmarks are run in the same GH instance here

@arthurfiorette
Copy link

Hey @Eomm, are they being run in a dedicated CI environment? I tried running them in a Free Github Actions Runner and it still got me different results every time.

https://github.com/kitajs/benchmarks/actions/workflows/benchmarks.yml

@mcollina
Copy link
Member

mcollina commented Apr 2, 2024

We are not running them on dedicated HW, just standard GH actions. I run them on my dedicated machine when I pull them for Fastify main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants