Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better reflect real-world API with bigger payloads #3

Open
abenhamdine opened this issue Sep 9, 2017 · 4 comments
Open

Better reflect real-world API with bigger payloads #3

abenhamdine opened this issue Sep 9, 2017 · 4 comments
Assignees
Labels
semver-minor Issue or PR that should land as semver minor

Comments

@abenhamdine
Copy link

abenhamdine commented Sep 9, 2017

Hello,

First, congrats for these nice & useful benchmarks !

I made a very simple benchmark here with fastify vs Express and found some intereresting data : see fastify/fastify#178 for the background.

The important point is : size of payload matters : with a big JSON payload, json stringification becomes the bottleneck, and fastify matches Express performance only if a schema is applied in fastify route, see fastify/fastify#178 (comment)

I would be glad to send a PR to add a new route in the tests, in order to test
a bigger payload, or you can directly copy the test data I used in my benchmark if you prefer !

@cagataycali cagataycali self-assigned this Sep 9, 2017
@cagataycali cagataycali added the semver-minor Issue or PR that should land as semver minor label Sep 9, 2017
@cagataycali
Copy link
Contributor

cagataycali commented Sep 9, 2017

What a lovely welcome, thank you. It makes me happy to help.
Response size matters.

If you add your tests like this,

  • benchmarks
    • ...
    • payloads
      • small
        • express
        • fastify
      • medium
        • express
        • fastify
      • big
        • express
        • fastify
      • huge
        • express
        • fastify

Then add list that'll help lot I think

@agauniyal
Copy link

@abenhamdine I would suggest using more than 1 tool for benchmarking as well because during my prev experience some of them tend to show variance b/w themselves as well as their versions too.

@cagataycali
Copy link
Contributor

I add bigger json for express, when I add for every package this issue will close.

@aichholzer
Copy link
Contributor

@abenhamdine -Better late than never, right?
In the next couple of days I will get some big payloads into the tests and make sure they get benchmarked properly. I will keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Issue or PR that should land as semver minor
Projects
None yet
Development

No branches or pull requests

4 participants