Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React logs warnings since 16.8.6 when the config passed to withEffects does not contain a Context property #144

Closed
Nimelrian opened this issue Apr 24, 2019 · 0 comments · Fixed by #145
Closed

React logs warnings since 16.8.6 when the config passed to withEffects does not contain a Context property #144

Nimelrian opened this issue Apr 24, 2019 · 0 comments · Fixed by #145

Comments

@Nimelrian
Copy link
Contributor

React 16.8.6 PR: facebook/react/pull/15226

The contextType of the WithEffects component created by withEffects is undefined and thus invalid when either no config object is passed to withEffects or the passed object does not contain a Context property.

refract/base/react/withEffects.ts

Line 42 in 2f671e3

public static contextType = config.Context

This causes React to log warnings in the console.

The contextType should only be set if the value in the config object is not undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default ContextType to null, to fix React warning fanduel-oss/refract
1 participant
@Nimelrian