Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

FancyApp Carousel plugin Sync expect a hardcode classname #2659

Open
wterh opened this issue Oct 28, 2022 · 1 comment
Open

FancyApp Carousel plugin Sync expect a hardcode classname #2659

wterh opened this issue Oct 28, 2022 · 1 comment

Comments

@wterh
Copy link

wterh commented Oct 28, 2022

Description
Carousel__slide uses the hardcode of slide classes at the same time, providing classNames: {}, but the content of 'slide' is ignored unless equal to .carousel__slide.

A demo is available here: https://codepen.io/Axeofblood/pen/oNyXZBa
If the thumbnail item doesn't have the .carousel__slide class, the click event will be ignored in Sync

To Reproduce
Steps to reproduce the behavior:

  1. Create Carousel
  2. Change class for slides
  3. Try click on thumbnails
  4. See

Expected behavior
Changing the class has no effect on click behavior

@fancyapps
Copy link
Owner

Hi,

thanks for the feedback, I'll take it into account.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants