Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Depreciated: HTMLVideoElement.webkitExitFullscreen() #2210

Open
acwolff opened this issue Mar 7, 2019 · 9 comments
Open

Depreciated: HTMLVideoElement.webkitExitFullscreen() #2210

acwolff opened this issue Mar 7, 2019 · 9 comments

Comments

@acwolff
Copy link

acwolff commented Mar 7, 2019

This video page in my FancyBox video example album gives in the Windows 10 Chrome debugger (F12) this warning:

jquery.fancybox.min.js:11 [Deprecation] 'HTMLVideoElement.webkitExitFullscreen()' is deprecated. Please use 'Document.exitFullscreen()' instead.

@fancyapps
Copy link
Owner

Hi,

Are you using outdated Chrome? The script checks unprefixed methods first and uses them, if available. Therefore I do not see such message when using the latest Chrome, because document.exitFullscreen() is available and the script uses it.

@fancyapps
Copy link
Owner

fancyapps commented Mar 7, 2019

Also, if you are posting a link to page like that, then, please, be more specific where your issue can be inspected, because there are many different variations/modifications in one place and it is hard to figure out where exactly to click. Or even better would be if you would point to bare minimum (e.g. codepen) demo.

@acwolff
Copy link
Author

acwolff commented Mar 7, 2019

Are you using outdated Chrome?

No. this I see in the help menu:
Google Chrome is up-to-date
Versie 72.0.3626.121 (Officiële build) (64-bits)

@acwolff
Copy link
Author

acwolff commented Mar 7, 2019

Also, if you are posting a link to page like that, then, please, be more specific where your issue can be inspected, because there are many different variations/modifications in one place and it is hard to figure out where exactly to click.

I don't understand you, you can inspect my page via F12
This is the link to the thumbnails page:
https://andrewolff.jalbum.net/FancyBoxVideoTest/

You see the warning if you go to the next slide.

warning

@fancyapps
Copy link
Owner

Try imagine from my point of view.

  1. You give a link to your page with description of some issue
  2. I open your page and I see lots of text and lots of various thumbnails
  3. I click on couple of them and everything seems to be fine
  4. I feel frustrated and annoyed
  5. Then I keep clicking until I find the right one
  6. OK, now I see

@fancyapps
Copy link
Owner

Anyway, I found the cause of the issue and will fix soon. Thanks for reporting.

@acwolff
Copy link
Author

acwolff commented Mar 7, 2019

Try imagine from my point of view.
4. I feel frustrated and annoyed

Sorry, I only try to help you and certainly not to frustate you!

@acwolff
Copy link
Author

acwolff commented Mar 7, 2019

Anyway, I found the cause of the issue and will fix soon. Thanks for reporting.

You are welcome!
Thanks again for your excellent library!

@acwolff acwolff closed this as completed Mar 7, 2019
fancyapps added a commit that referenced this issue Mar 11, 2019
- Fixed #2213 keyboard navigation inside form dropdowns
- Fixed #2210 - Depreciated: HTMLVideoElement.webkitExitFullscreen()
@acwolff acwolff reopened this Mar 12, 2019
@acwolff acwolff closed this as completed Mar 12, 2019
@acwolff
Copy link
Author

acwolff commented Mar 12, 2019

I am sorry to say that this problem has not been solved in version 3.5.7, I still get the warning as showed in the screenshot above.

@acwolff acwolff reopened this Mar 12, 2019
jeremiah-rs added a commit to jeremiah-rs/fancybox that referenced this issue Mar 20, 2019
- Fixed fancyapps#2213 keyboard navigation inside form dropdowns
- Fixed fancyapps#2210 - Depreciated: HTMLVideoElement.webkitExitFullscreen()
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants