Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix up sphinx tabs 馃寶 #2045

Merged
merged 1 commit into from Mar 23, 2022
Merged

Conversation

kgriffs
Copy link
Member

@kgriffs kgriffs commented Mar 23, 2022

Tested on Firefox, Brave, Safari. Also Brave w/ Dark Reader.

@kgriffs kgriffs requested review from vytas7 and CaselIT March 23, 2022 02:01
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #2045 (dcc0b22) into master (294d434) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2045   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6707      6707           
  Branches      1238      1238           
=========================================
  Hits          6707      6707           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 294d434...dcc0b22. Read the comment docs.

@@ -400,7 +400,7 @@ commands =
basepython = python3.8
deps = -r{toxinidir}/requirements/docs
commands =
sphinx-build -W -E -b html docs docs/_build/html []
sphinx-build -j auto -W -E -b html docs docs/_build/html []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shaved 10s off my local build time, so thought I'd just leave it in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use the makefile

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good 馃挴

@CaselIT could you also give this a sanity check on your browsers/settings?

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine also to me

@vytas7 vytas7 merged commit 0f7be6e into falconry:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants