Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prep for 3.1.0 release #2036

Merged
merged 5 commits into from Mar 12, 2022
Merged

Conversation

kgriffs
Copy link
Member

@kgriffs kgriffs commented Mar 11, 2022

Summary of Changes

Add RELEASE.md and prep for 3.1.0rc1

@kgriffs kgriffs requested review from vytas7 and CaselIT March 11, 2022 04:38
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #2036 (d055892) into master (89a615a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2036   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6707      6707           
  Branches      1238      1238           
=========================================
  Hits          6707      6707           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a615a...d055892. Read the comment docs.

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍
You haven't removed the news fragments yet. Do we want to keep them for some time even though the report has been rendered?

@kgriffs
Copy link
Member Author

kgriffs commented Mar 11, 2022

Oops, forgot to rm the news fragment files. Let me do that.

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sans removal of newsfragments 💯
(And there are a couple of non-critical sphinx-isms in RELEASE.md.)

RELEASE.md Outdated Show resolved Hide resolved
@kgriffs kgriffs requested a review from vytas7 March 11, 2022 22:26
vytas7
vytas7 previously approved these changes Mar 11, 2022
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

RELEASE.md Show resolved Hide resolved
@vytas7 vytas7 merged commit f2de3bd into falconry:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants