Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unannounced breaking change in renaming falcon.api_helpers #1902

Closed
vytas7 opened this issue Apr 6, 2021 · 2 comments · Fixed by #1904
Closed

Unannounced breaking change in renaming falcon.api_helpers #1902

vytas7 opened this issue Apr 6, 2021 · 2 comments · Fixed by #1904
Assignees
Labels
Milestone

Comments

@vytas7
Copy link
Member

vytas7 commented Apr 6, 2021

The falcon.api_helpers module used to contain several semi-public (not documented, but not underscored either) utilities, that people may be relying on.

During the 3.0 release cycle, falcon.api_helpers was renamed to falcon.app_helpers in order to reflect the API ➡️ App renaming.
However, the old name disappeared without any deprecation notice, and without any information in the 3.0 changelog notes. This is a bug.

In the spirit of SemVer, we cannot afford marking the change as deprecation in 3.0.1 either.
Let us make the name available as-is in 3.0.1, and mark as deprecated in 3.1; remove in 4.0.

@vytas7
Copy link
Member Author

vytas7 commented Apr 6, 2021

This is used by Sentry's Falcon integration plugin, so we need to make sure the coming fix re-enables that plugin at least on the import level.

@kgriffs
Copy link
Member

kgriffs commented May 10, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants