Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link for placeholdit #2356

Merged
merged 1 commit into from Jul 9, 2021
Merged

fix broken link for placeholdit #2356

merged 1 commit into from Jul 9, 2021

Conversation

lilisako
Copy link
Contributor

@lilisako lilisako commented Jul 9, 2021

Issue#

#2328

Description:

Just specify the image size after our URL (https://via.placeholder.com/) and you’ll get a placeholder image.

C/O https://placeholder.com/

Before

> Faker::Placeholdit.image
https://placehold.it/300x300.png
> Faker::Placeholdit.image(size: '50x50')
https://placehold.it/50x50.png

After

> Faker::Placeholdit.image
https://via.placeholder.com/300x300.png
> Faker::Placeholdit.image(size: '50x50')
https://via.placeholder.com/50x50.png

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you squash your commits into one?

fix url for test
@lilisako
Copy link
Contributor Author

lilisako commented Jul 9, 2021

@koic Thanks for the prompt response! I squashed the commits as you said.
Thanks in advance,
Risako

@koic koic merged commit 4ef9a86 into faker-ruby:master Jul 9, 2021
@koic
Copy link
Member

koic commented Jul 9, 2021

Thanks!

@lilisako lilisako deleted the issue#2328 branch July 9, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants