Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Hobby to default #2341

Merged
merged 2 commits into from Jun 29, 2021
Merged

add Hobby to default #2341

merged 2 commits into from Jun 29, 2021

Conversation

rohanphillips
Copy link
Contributor

@rohanphillips rohanphillips commented Jun 23, 2021

Issue# Add Hobby's

Add-Hobby

Description:

Add the ability for Faker to produce random hobbies.

  • Initial structure for Hobby has been laid out for future expansion
  • I assumed that the coverage/index.html file is regenerated automatically?

# @example
# Faker::Hobby.activity #=> "Cooking"
#
# @faker.version 2.18.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you convert this to next as documented in CONTRIBUTING.md (here and other places): https://github.com/faker-ruby/faker/blob/master/CONTRIBUTING.md

@rohanphillips
Copy link
Contributor Author

Changes made as requested

@rohanphillips rohanphillips requested a review from psibi June 26, 2021 21:48
@psibi psibi merged commit cbe6017 into faker-ruby:master Jun 29, 2021
@psibi
Copy link
Member

psibi commented Jun 29, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants