From c42edfcd40098bb1feb0b4be276f0f08f56d0b97 Mon Sep 17 00:00:00 2001 From: Yuji Hanamura Date: Fri, 21 May 2021 03:39:18 +0900 Subject: [PATCH 1/2] Fix `Faker::Color.color_name` for Japanese --- lib/locales/ja/color.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/locales/ja/color.yml b/lib/locales/ja/color.yml index 610405039b..3201ae098b 100644 --- a/lib/locales/ja/color.yml +++ b/lib/locales/ja/color.yml @@ -1,4 +1,4 @@ ja: faker: color: - name: ["赤", "緑", "青", "黄", "紫", "ミントグリーン", "ティール", "白", "黒", "オレンジ", "ピンク", "灰色", "栗色", "バイオレット", "ターコイズブルー", "タン", "空色", "サーモン", "プラム", "オーキッド", "オリーブ", "マゼンタ", "ライム", "アイボリー", "藍色", "金", "フクシア", "シアン", "紺碧", "ラベンダー", "銀"] + name: ["赤", "緑", "青", "黄", "紫", "ミントグリーン", "ティール", "白", "黒", "オレンジ", "ピンク", "灰色", "栗色", "バイオレット", "ターコイズブルー", "タン", "空色", "サーモン", "プラム", "オーキッド", "オリーブ", "マゼンタ", "ライム", "アイボリー", "藍色", "金", "フクシア", "シアン", "紺碧", "ラベンダー", "銀"] From 11337207cfd7f8e234bd6e7809a4c0a913005ae8 Mon Sep 17 00:00:00 2001 From: Yuji Hanamura Date: Fri, 21 May 2021 03:39:18 +0900 Subject: [PATCH 2/2] Add assertion of `Faker::Color.color_name` for Japanese --- test/test_ja_locale.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_ja_locale.rb b/test/test_ja_locale.rb index 026502cb2c..247a5bf658 100644 --- a/test/test_ja_locale.rb +++ b/test/test_ja_locale.rb @@ -42,6 +42,7 @@ def test_ja_cat_methods def test_ja_color_methods assert Faker::Color.color_name.is_a? String + assert_not_english(Faker::Color.color_name) end def test_ja_book_methods