Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Faker::Color.color_name for Japanese #2329

Merged
merged 2 commits into from May 21, 2021

Conversation

yujideveloper
Copy link
Contributor

No-Story

Description:

Sorry, I introduced a bug in #2315.

@yujideveloper yujideveloper changed the title Fix Faker::Color.name for Japanese Fix Faker::Color.name for Japanese May 20, 2021
@yujideveloper yujideveloper changed the title Fix Faker::Color.name for Japanese Fix Faker::Color.color_name for Japanese May 20, 2021
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbrazo vbrazo merged commit c4c8a94 into faker-ruby:master May 21, 2021
@yujideveloper yujideveloper deleted the fix/color-name-in-ja branch May 21, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants