Remove trailing spaces from translations #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trailing spaces between the translation and its final quotation make causes issues when performing actions on strings, such as pluralization.
|
Nice! It would be ideal if the build process could detect these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
Some returned strings have trailing whitespace. I found this when using
Faker::Creature::Animal.unique.name.pluralizeand the result was"turtle s". I checked the Faker translations and found 31 examples of a trailing whitespace before the closing quotation mark.The trailing space was unexpected and it seems like it is unintentional in all present cases.
Description:
This PR finds and removes the trailing whitespace before the closing quotation mark of the affected translations.