Split JA translation file into one file per class #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is having it in a single file causing any issues ? Apart from en, all other locales are put into the same file. Also, this would break downstream consumes of faker that assumes other locales are in a single file: https://github.com/fakedata-haskell/fakedata |
|
There is maintainability issue, but nothing else. |
|
@yujideveloper I didn't about that MR, if not I would have commented there itself. Given the scenario, let's get this merged. Do you know why the CI is failing ? |
|
Ah, I see. Thanks for your contribution! |
gongo
added a commit
to gongo/faker
that referenced
this pull request
May 18, 2021
vbrazo
pushed a commit
that referenced
this pull request
May 30, 2021
* 🐛 Fix indentation ( `ja.faker.name` to `ja.faker.color.name` ) via #2315 * 🎨 Convert a huge one-line array to multiple lines Because the file cannot be opened with a weak editor... * 🐛 Japanese postcode has a hyphen. via: #2297 * Update test/test_ja_locale.rb Co-authored-by: Koichi ITO <koic.ito@gmail.com> Co-authored-by: Koichi ITO <koic.ito@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-StoryDescription:
I split JA translation file into one file per class like EN translation files