Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Australia class #2245

Merged
merged 12 commits into from Aug 21, 2021
Merged

Add Faker::Australia class #2245

merged 12 commits into from Aug 21, 2021

Conversation

astley92
Copy link
Contributor

Description:

Created Australian category and included locations, animals and states.

Faker::Autralia.location => 'Sydney'
Faker::Autralia.animal => 'Kangaroo'
Faker::Autralia.state => 'New South Wales'

gday

@astley92 astley92 changed the title Add Australian category Add Faker::Australia class Jan 28, 2021
@astley92
Copy link
Contributor Author

@gabrielbaldao Thanks for approving this one. Is this able to be merged or anything else I should be doing here?

@astley92 astley92 requested a review from psibi August 20, 2021 11:35
@psibi psibi merged commit a40905f into faker-ruby:master Aug 21, 2021
@psibi
Copy link
Member

psibi commented Aug 21, 2021

Thank you!

@@ -0,0 +1,47 @@
# frozen_string_literal: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add this generator to the README.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a doc/default/australia.md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants