Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Music#mambo_no_5, a Generator for Random First Names that Appear in Lou Bega's Mambo No. 5 #1910

Merged
merged 9 commits into from Apr 13, 2021

Conversation

NickyEXE
Copy link
Contributor

No-Story

Description:

This is a unique faker generator for generating first names, where all first names are names mentioned in Lou Bega's 1999 song "Mambo No. 5 (A Little Bit of...)".

It will be used largely for seeding data for first names for test applications.

I'm a coach at a coding bootcamp and always am looking for new weird faker modules to use for seeding data when demonstrating ideas to students. While there are a lot of fun ones that see a lot of use, there are relatively few for first names that don't have to do with TV shows (there are only so many labs you can do where everyone's named Danaerys). For fun and out of appreciation for Lou Bega, I made this PR.

@NickyEXE NickyEXE changed the title Finished with all tests passing Added Faker::Music::Mambo, a Generator for First Names Sourcing Mambo #5 Jan 15, 2020
@NickyEXE NickyEXE changed the title Added Faker::Music::Mambo, a Generator for First Names Sourcing Mambo #5 Added Faker::Music::Mambo, a Generator for Random First Names that Appear in Lou Bega's Mambo No. 5 Jan 15, 2020
@NickyEXE NickyEXE requested review from Zeragamba and vbrazo and removed request for Zeragamba January 21, 2020 14:58
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, however I think is a bit too small of a generator to include.

@Zeragamba
Copy link
Contributor

I think if this was moved to Faker::Music.mambo it would work a bit better

lib/locales/mambo.yml Outdated Show resolved Hide resolved
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a single comment (and @Zeragamba other comments which needs to be addressed)

@NickyEXE NickyEXE changed the title Added Faker::Music::Mambo, a Generator for Random First Names that Appear in Lou Bega's Mambo No. 5 Add Faker::Music#mambo_no_5, a Generator for Random First Names that Appear in Lou Bega's Mambo No. 5 Apr 8, 2021
@NickyEXE NickyEXE requested a review from psibi April 8, 2021 21:19
@NickyEXE
Copy link
Contributor Author

NickyEXE commented Apr 8, 2021

I made several changes to the pull request to address notes here.

Per Zeragamba's note:

I think if this was moved to Faker::Music.mambo it would work a bit better

I instead made #mambo_no_5 a method on Faker::Music (I worried mambo may be too ambiguous of a method name).

I think the new pull request captures all the notes. Appreciate the reviews.

lib/faker/music/music.rb Outdated Show resolved Hide resolved
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a minor change that is required.

Co-authored-by: Sibi Prabakaran <psibi2000@gmail.com>
@psibi psibi merged commit b33a4e4 into faker-ruby:master Apr 13, 2021
@psibi
Copy link
Member

psibi commented Apr 13, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants