Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "mint green" from list of colors #1764

Merged
merged 1 commit into from Sep 27, 2019
Merged

Conversation

ro-savage
Copy link
Contributor

The list of colors are all single words except for "mint green".

As mint green is a pretty obscure color and doesn't fit with the format of every other color being a single word.

I purpose we remove this color for consistency.

Issue#: No-Story

The list of colors are all single words except for "mint green".

As mint green is a pretty obscure color and doesn't fit with the format of every other color being a single word.

I purpose we remove this color for consistency.
@ro-savage ro-savage changed the title Remove "mint green" from color Remove "mint green" from list of colors Sep 27, 2019
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok for me too

@vbrazo vbrazo merged commit 71fe3a6 into faker-ruby:master Sep 27, 2019
@ro-savage ro-savage deleted the patch-1 branch September 27, 2019 06:20
sanikkenway added a commit to sanikkenway/faker that referenced this pull request Sep 30, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
The list of colors are all single words except for "mint green".

As mint green is a pretty obscure color and doesn't fit with the format of every other color being a single word.

I purpose we remove this color for consistency.
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
The list of colors are all single words except for "mint green".

As mint green is a pretty obscure color and doesn't fit with the format of every other color being a single word.

I purpose we remove this color for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants