Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YARD docs for the Basketball and Football fakers. #1761

Merged
merged 1 commit into from Sep 21, 2019

Conversation

connorshea
Copy link
Member

Title pretty much says it all.

Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the title is correct. Looks good to me.

@connorshea connorshea mentioned this pull request Sep 21, 2019
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Gonna do a normal merge. You guys should deserve some contribution kudos.

@vbrazo vbrazo merged commit 1e60543 into faker-ruby:master Sep 21, 2019
@connorshea connorshea deleted the add-sports-docs branch September 22, 2019 21:50
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Add YARD docs for the Basketball and Football fakers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants