Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Faker::Name.first_name by locale #2620

Closed
loqimean opened this issue Nov 8, 2022 · 3 comments · Fixed by #2622
Closed

Typo in Faker::Name.first_name by locale #2620

loqimean opened this issue Nov 8, 2022 · 3 comments · Fixed by #2622
Assignees
@jremes-foss
Labels
🐞 Issue: Bug

Comments

@loqimean
Copy link
Contributor

loqimean commented Nov 8, 2022

There is a typo in Ukrainian name "Геннадій", it should be "Генадій", so, one letter is extra

To Reproduce

Faker::VERSION #=> "2.22.0"

With locale :uk and
Faker::Name.first_name get "Геннадій", but expected "Генадій"
@jremes-foss jremes-foss self-assigned this Nov 8, 2022
jremes-foss added a commit to jremes-foss/faker-1 that referenced this issue Nov 8, 2022
@jremes-foss
Fix a typo in Ukrainian locale, fixes faker-ruby#2620
209256c
@jremes-foss jremes-foss mentioned this issue Nov 8, 2022
Merged
@jremes-foss
Copy link
Contributor

Hi @loqimean. Thanks for reporting this. I have created a pull request to fix the issue.

Thank you.

jremes-foss added a commit that referenced this issue Nov 10, 2022
@jremes-foss
Merge pull request #2622 from Newman101/fix-issue-2620
6098379 
Typo in Ukrainian locale, fixes #2620
@bodiam
Copy link

bodiam commented Jan 12, 2023

This change doesn't seem to be correct. The correct spelling should be with 2x H, also validated with a Ukrainian friend.

https://uk.wikipedia.org/wiki/%D0%93%D0%B5%D0%BD%D0%BD%D0%B0%D0%B4%D1%96%D0%B9

thdaraujo added a commit that referenced this issue Jan 25, 2023
@thdaraujo
Revert "Typo in Ukrainian locale, fixes #2620"
baa4b57
@thdaraujo thdaraujo mentioned this issue Jan 25, 2023
Merged
thdaraujo added a commit that referenced this issue Jan 25, 2023
@thdaraujo
Revert "Typo in Ukrainian locale, fixes #2620" (#2690)
1c868b2
@thdaraujo
Copy link
Contributor

This change doesn't seem to be correct. The correct spelling should be with 2x H, also validated with a Ukrainian friend.

https://uk.wikipedia.org/wiki/%D0%93%D0%B5%D0%BD%D0%BD%D0%B0%D0%B4%D1%96%D0%B9

reverted in #2690
thanks for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jremes-foss jremes-foss

Labels
🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typo in Ukrainian locale, fixes #2620 jremes-foss/faker-1
4 participants
@bodiam @thdaraujo @jremes-foss @loqimean