Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FR translation for animals #2333

Merged
merged 1 commit into from Jun 4, 2021
Merged

Conversation

cprodhomme
Copy link
Contributor

Issue#

No-Story

Description:

add French translation for animals because in french, some animals have different name that in english

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding animals in french. Could you please add a test for this new locale?

@cprodhomme
Copy link
Contributor Author

Thanks for adding animals in french. Could you please add a test for this new locale?

Done !

@vbrazo vbrazo merged commit 8e8ae22 into faker-ruby:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants