Add birds #2299
Merged
Add birds #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correcting tests for adjectives and common_name roots
…ommon_name string be lowercase
…common_names and #test_implausible_common_names more clear
…names like "Painted bunting"
koic
reviewed
Apr 17, 2021
koic
reviewed
Apr 17, 2021
|
I left two comments about API docs. Can you apply to APIs added in this PR? |
Co-authored-by: Koichi ITO <koic.ito@gmail.com>
…mes and #common_name accepts a parameter for the order to restrict on
…#order_with_common_names work properly
…mon_name more robust when passed a bad parameter
|
Can you add the generator to README.md? |
Yes, sure thing! Also, I have a few other changes that occurred to me as I was playing around with this over the weekend. They appear to be doing what I (now) expect of them, but I am a little concerned that I might have implemented somethings in an unorthodox manner. Just a heads up 😅 |
koic
reviewed
Apr 20, 2021
Co-authored-by: Koichi ITO <koic.ito@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-StoryDescription:
I'm working on a tool for birders to assist in the identification of different bird species. As such, in order to test this, it would be good to have data that mimics bird naming conventions. This is what that is.