Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase french entropy #2289

Merged
merged 2 commits into from Apr 11, 2021
Merged

Increase french entropy #2289

merged 2 commits into from Apr 11, 2021

Conversation

meuble
Copy link
Contributor

@meuble meuble commented Mar 26, 2021

Issue#

No-Story

Description:

This pull request increases the entropy of names and addresses in the French translation. It just adds more female and male first names, as well as the most common French last names.

Also, it adds more diversity to the gender list, accounting for other non-binary genders.

Is it a good idea to split a single YML file like for the EN translation?

Thanks!

@vbrazo vbrazo merged commit 912632c into faker-ruby:master Apr 11, 2021
@vbrazo
Copy link
Member

vbrazo commented Apr 11, 2021

I like it. @meuble Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants