Add Faker::Tea #2190
Merged
Add Faker::Tea #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Apr 16, 2021
koic
reviewed
Apr 16, 2021
koic
reviewed
Apr 16, 2021
koic
reviewed
Apr 16, 2021
|
Can you add the docs to README.md and lib/faker/default/tea.md? E.g.: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds a new Faker generator for tea. It seems appropriate given that
Faker::Coffeealready exists. Its use case is for when people want to have types of tea as filler data. There are two methods onFaker::Teathat can be used they aretypeandvariety, the latter of which optionally takes atype:positional arg, which limits the scope.