Workaround for cc-test-reporter with SimpleCov 0.18 #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can probably hold out on updating simplecov till the test-reporter is updated. We can manually trigger re-runs of the tests from Dependabot's PR's checks Page |
koic
force-pushed
the
workaround_for_cc_test_reporter_with_simplecov
branch
from
bb83f68
to
57f01b0
Compare
|
Thanks for your suggestion. OTOH, the source code comment for gemspec explains why the version is pinned, so I think it's clear when maintainers can unpin it. What do you think about it? |
koic
force-pushed
the
workaround_for_cc_test_reporter_with_simplecov
branch
2 times, most recently
from
1d9d0c3
to
1aab78c
Compare
koic
force-pushed
the
workaround_for_cc_test_reporter_with_simplecov
branch
from
1aab78c
to
1f378b8
Compare
Closes faker-ruby#2241. This PR fixes the following build error when using cc-test-reporter with SimpleCov 0.18. ```console Run export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}" Error: json: cannot unmarshal object into Go struct field input.coverage of type []formatters.NullInt Usage: cc-test-reporter after-build [flags] (snip) Global Flags: -d, --debug run in debug mode ##[error]Process completed with exit code 255. ``` https://github.com/faker-ruby/faker/pull/2043/checks?check_run_id=750522010 This patch is a workaround until the following issue will be resolved. codeclimate/test-reporter#418
koic
force-pushed
the
workaround_for_cc_test_reporter_with_simplecov
branch
from
1f378b8
to
60988bb
Compare
|
I'm going to merge this patch because the issue is still unlikely to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2043.
This PR fixes the following build error when using cc-test-reporter with SimpleCov 0.18.
https://github.com/faker-ruby/faker/pull/2043/checks?check_run_id=750522010
This patch is a workaround until the following issue will be resolved.
codeclimate/test-reporter#418