Drop EOL Rubies from CI tests #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 2.3 was EOL March 31, 2019
- 2.4 was EOL March 31, 2020
lucasqueiroz
approved these changes
Jun 6, 2020
koic
added a commit
to koic/faker
that referenced
this pull request
Jun 18, 2020
Follow up faker-ruby#2038. This PR uses `match?`. Since Ruby 2.4, `match?` method has been introduced. If `MatchData` is not captured, it is faster to use `match?`.
Closed
koic
added a commit
to koic/faker
that referenced
this pull request
Jun 19, 2020
Follow up faker-ruby#2038. This PR uses `match?`. Since Ruby 2.4, `match?` method has been introduced. If `MatchData` is not captured, it is faster to use `match?`.
vbrazo
added
💡 Issue: Feature Request
Chores
and removed
💡 Issue: Feature Request
labels
koic
added a commit
to koic/faker
that referenced
this pull request
Jul 17, 2020
Follow up faker-ruby#2038. Faker has been dropped support for Ruby 2.4.
Zeragamba
pushed a commit
that referenced
this pull request
Jul 17, 2020
Follow up #2038. Faker has been dropped support for Ruby 2.4.
koic
added a commit
to koic/faker
that referenced
this pull request
Jul 18, 2020
Follow up faker-ruby#2038 and faker-ruby#2081. This PR enables `Lint/UnifiedInteger` cop.
gabrielbaldao
pushed a commit
to gabrielbaldao/faker
that referenced
this pull request
Jul 22, 2020
Follow up faker-ruby#2038. Faker has been dropped support for Ruby 2.4.
gabrielbaldao
pushed a commit
to gabrielbaldao/faker
that referenced
this pull request
Jul 22, 2020
Follow up faker-ruby#2038 and faker-ruby#2081. This PR enables `Lint/UnifiedInteger` cop.
koic
added a commit
to koic/faker
that referenced
this pull request
Aug 1, 2020
Follow up faker-ruby#2038. This PR uses `match?`. Since Ruby 2.4, `match?` method has been introduced. If `MatchData` is not captured, it is faster to use `match?`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops Ruby 2.3 and Ruby 2.4 from the list of automatically tested Ruby versions.