Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize some tests #2028

Merged
merged 3 commits into from May 31, 2020
Merged

Reorganize some tests #2028

merged 3 commits into from May 31, 2020

Conversation

connorshea
Copy link
Member

This reorganizes some test files that were poorly organized :)

  • Move all games tests into the test/faker/games dir. Lots of games were still in the default/ directory when they shouldn't have been.
  • Merge the two movie faker test files.
  • Remove duplicate Dune faker test.

@connorshea connorshea changed the title Reorganize tests Reorganize some tests May 31, 2020
vbrazo
vbrazo approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbrazo vbrazo merged commit 9c7bb61 into faker-ruby:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

@lucasqueiroz lucasqueiroz lucasqueiroz approved these changes

@Zeragamba Zeragamba Awaiting requested review from Zeragamba

Assignees
No one assigned
Labels
Chores 🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@connorshea @vbrazo @lucasqueiroz