Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Movie.title #1952

Merged
merged 1 commit into from May 31, 2020
Merged

Conversation

gizipp
Copy link
Contributor

@gizipp gizipp commented Mar 25, 2020

Summary

Add a new method #title for Faker::Movie

Faker::Movie.title  #=> The Lord of the Rings: The Two Towers

Issue

No-Story

Description:

Today I had the need to fake data for movie titles, e.g The Hobbit, Terminator, The Lord of The Rings, etc

Unfortunately, Faker::Movie only have #quote method (which is it looks like only for fun and not really needed), so I think we need to add Faker::Movie.title

P.S : I also thinking add Faker::Movie.genre #=> Comedy next.

@Zeragamba Zeragamba assigned Zeragamba and unassigned Zeragamba May 23, 2020
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/faker/default/test_faker_movie.rb already exists, we should move the quote test from that file into your new test/faker/movies/test_faker_movie.rb file and then delete test/faker/default/test_faker_movie.rb, but we can do that in a separate PR.

@connorshea connorshea merged commit 99e8888 into faker-ruby:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants