Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add YARD doc for Faker::Coin #1803

Merged
merged 3 commits into from Nov 14, 2019
Merged

add YARD doc for Faker::Coin #1803

merged 3 commits into from Nov 14, 2019

Conversation

sap1enza
Copy link
Contributor

Issue#

#1762

Description:

Add complete YARD docs for Faker::Coin methods.

connorshea
connorshea requested changes Nov 13, 2019
View reviewed changes
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, other than that it looks good to me. Thanks!

lib/faker/default/coin.rb Outdated Show resolved Hide resolved
lib/faker/default/coin.rb Outdated Show resolved Hide resolved
sap1enza and others added 2 commits November 12, 2019 22:17
@sap1enza @connorshea
Update lib/faker/default/coin.rb
847b0af 
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@sap1enza @connorshea
Update lib/faker/default/coin.rb
756af36 
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@connorshea connorshea mentioned this pull request Nov 13, 2019
Closed
connorshea
connorshea approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vbrazo
vbrazo approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit d8e48fa into faker-ruby:master Nov 14, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@sap1enza @connorshea @michebble
add YARD doc for Faker::Coin (faker-ruby#1803)
b609fab 
* add coin docs

* Update lib/faker/default/coin.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Update lib/faker/default/coin.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@sap1enza @connorshea @vbrazo
add YARD doc for Faker::Coin (faker-ruby#1803)
141d01c 
* add coin docs

* Update lib/faker/default/coin.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Update lib/faker/default/coin.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

@connorshea connorshea connorshea approved these changes

Assignees

@sap1enza sap1enza

Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sap1enza @vbrazo @connorshea