Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup world_cup YARD docs #1799

Merged
merged 1 commit into from Nov 13, 2019
Merged

Cleanup world_cup YARD docs #1799

merged 1 commit into from Nov 13, 2019

Conversation

DevUsmanGhani
Copy link
Contributor

Issue#

No-Story

Description:

Cleans up documentation for world_cup.rb to be more consistent.

@DevUsmanGhani DevUsmanGhani changed the title Remove 'See below examples' for consistency Cleanup world_cup documentation Oct 10, 2019
@DevUsmanGhani DevUsmanGhani changed the title Cleanup world_cup documentation Cleanup world_cup YARD docs Oct 10, 2019
connorshea
connorshea approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vbrazo vbrazo merged commit a034f40 into faker-ruby:master Nov 13, 2019
@DevUsmanGhani DevUsmanGhani deleted the cleanup-world-cup-documentation branch November 13, 2019 14:39
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@DevUsmanGhani @michebble
Remove 'See below examples' for consistency (faker-ruby#1799)
22460b0
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@DevUsmanGhani @vbrazo
Remove 'See below examples' for consistency (faker-ruby#1799)
9a0a9eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

@connorshea connorshea connorshea approved these changes

Assignees

@DevUsmanGhani DevUsmanGhani

Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DevUsmanGhani @vbrazo @connorshea