Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two incorrect flexible method calls. #1767

Merged
merged 1 commit into from Sep 29, 2019

Conversation

connorshea
Copy link
Member

These two were referring to a key that didn't make sense for the class they were in.

I'm not entirely sure I understand what 'flexible' does, so please correct me if I'm using it wrong :)

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 💯

@vbrazo vbrazo merged commit 404c9fd into faker-ruby:master Sep 29, 2019
@connorshea connorshea deleted the fix-incorrect-flexibles branch September 29, 2019 20:58
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants