add brand, vendor support to commerce (#1601) #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishra0
changed the title
bpleslie
reviewed
Sep 9, 2019
bpleslie
approved these changes
Sep 9, 2019
| @@ -23,4 +23,10 @@ Faker::Commerce.promotion_code #=> "AmazingDeal829102" | |||
| Faker::Commerce.promotion_code(digits: 2) #=> "AmazingPrice57" | |||
|
|
|||
| Faker::Commerce.material #=> "Plastic" | |||
|
|
|||
| # Generate a random brand | |||
| Faker::Commerce.brand #=> "Apple" | |||
There was a problem hiding this comment.
Nice ! I will want to use this as well
Zeragamba
requested changes
Sep 10, 2019
ashishra0
force-pushed
the
add-brands-vendors
branch
from
77f3b9d
to
b970483
Compare
Zeragamba
approved these changes
Sep 19, 2019
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
a2a9f17
to
4384168
Compare
|
@vbrazo, @Zeragamba are we good to merge this? Let me know if something is missing! |
|
Thank you! |
|
@psibi excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1601
The new brand method on Faker::Commerce will result in this
The new vendor method on Faker::Commerce will result in this