Add user generator that accepts arguments (#1671) #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new user class method will now allow you to do this
```
user = Faker::Internet.user('name', 'email', password')
=> {'name' => 'John Doe', 'email' => 'fake_email@test.com', 'password' => 'pass123' }
```
bpleslie
approved these changes
Sep 19, 2019
bpleslie
reviewed
Sep 19, 2019
The new user class method will now allow you to do this
```
user = Faker::Internet.user('name', 'email', password')
=> {'name' => 'John Doe', 'email' => 'fake_email@test.com', 'password' => 'pass123' }
```
…add-user-generator
The new user class method will now allow you to do this
```
user = Faker::Internet.user('name', 'email', password')
=> {'name' => 'John Doe', 'email' => 'fake_email@test.com', 'password' => 'pass123' }
```
…add-user-generator
|
Could you rebase with master? |
…-user-generator
|
I just did |
|
@vbrazo are we good to merge? |
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
a2a9f17
to
4384168
Compare
Zeragamba
requested changes
Jun 10, 2020
Zeragamba
approved these changes
Jun 10, 2020
|
@Zeragamba got it, Will fix these conflicts! |
|
Fixed the conflicts, @Zeragamba, @psibi could you please verify if the changes are in order? If not I will fix it :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new user class method will now allow you to do this