Skip to content

Fix changelog versions #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2019
Merged

Fix changelog versions #1715

merged 5 commits into from
Aug 31, 2019

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Aug 31, 2019

Issue#

Closes #1713

Description:

Changelog link versions are broken

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lucasqueiroz
Copy link
Member

Everything else looks fine 👍

vbrazo and others added 4 commits August 31, 2019 01:43

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>
@vbrazo vbrazo merged commit 772d45d into master Aug 31, 2019
@vbrazo vbrazo deleted the vbrazo-patch-1 branch August 31, 2019 05:48
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
* Update CHANGELOG.md

* Apply suggestions from code review

Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Update CHANGELOG.md

* Apply suggestions from code review

Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Lucas Queiroz <lucascqueiroz97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change log version links don't work
2 participants