From dc1f44c4b7a9a410a9fc641c9acca575fea15121 Mon Sep 17 00:00:00 2001 From: Brad Charna Date: Thu, 21 Feb 2019 22:02:45 -0800 Subject: [PATCH] Faker::Movies::GratefulDead => Faker::Music::GratefulDead --- doc/unreleased/music/grateful_dead.md | 8 +++++++ .../unreleased/movies/grateful_dead.rb | 22 +++++++++++++++++++ lib/faker/{movies => music}/grateful_dead.rb | 4 +++- lib/locales/en/grateful_dead.yml | 3 ++- .../test_deprecate_faker_grateful_dead.rb} | 2 +- test/faker/music/test_faker_grateful_dead.rb | 17 ++++++++++++++ unreleased_README.md | 2 +- 7 files changed, 54 insertions(+), 4 deletions(-) create mode 100644 doc/unreleased/music/grateful_dead.md create mode 100644 lib/faker/deprecate/unreleased/movies/grateful_dead.rb rename lib/faker/{movies => music}/grateful_dead.rb (86%) rename test/{faker/movies/test_faker_grateful_dead.rb => deprecate/unreleased/test_deprecate_faker_grateful_dead.rb} (79%) create mode 100644 test/faker/music/test_faker_grateful_dead.rb diff --git a/doc/unreleased/music/grateful_dead.md b/doc/unreleased/music/grateful_dead.md new file mode 100644 index 0000000000..14a17047ac --- /dev/null +++ b/doc/unreleased/music/grateful_dead.md @@ -0,0 +1,8 @@ +# Faker::Music::GratefulDead + + +```ruby + Faker::Music::GratefulDead.player #=> "Jerry Garcia" + + Faker::Music::GratefulDead.song #=> "Cassidy" +``` diff --git a/lib/faker/deprecate/unreleased/movies/grateful_dead.rb b/lib/faker/deprecate/unreleased/movies/grateful_dead.rb new file mode 100644 index 0000000000..e4397763e3 --- /dev/null +++ b/lib/faker/deprecate/unreleased/movies/grateful_dead.rb @@ -0,0 +1,22 @@ +# frozen_string_literal: true + +module Faker + module Movies + class GratefulDead < Base + class << self + extend Gem::Deprecate + + def player + Faker::Music::GratefulDead.player + end + + def song + Faker::Music::GratefulDead.song + end + + deprecate :player, 'Faker::Music::GratefulDead.player', 2019, 04 + deprecate :song, 'Faker::Music::GratefulDead.song', 2019, 04 + end + end + end +end diff --git a/lib/faker/movies/grateful_dead.rb b/lib/faker/music/grateful_dead.rb similarity index 86% rename from lib/faker/movies/grateful_dead.rb rename to lib/faker/music/grateful_dead.rb index 60bf6ce47a..38ad96dfc1 100644 --- a/lib/faker/movies/grateful_dead.rb +++ b/lib/faker/music/grateful_dead.rb @@ -1,7 +1,9 @@ # frozen_string_literal: true +require_relative 'music' + module Faker - module Movies + class Music class GratefulDead < Base class << self def player diff --git a/lib/locales/en/grateful_dead.yml b/lib/locales/en/grateful_dead.yml index dad9c4e867..bf511fb5a0 100644 --- a/lib/locales/en/grateful_dead.yml +++ b/lib/locales/en/grateful_dead.yml @@ -44,4 +44,5 @@ en: "The Music Never Stopped", "Black Muddy River", "Looks Like Rain", - "Bird Song"] + "Bird Song", + "Cassidy"] diff --git a/test/faker/movies/test_faker_grateful_dead.rb b/test/deprecate/unreleased/test_deprecate_faker_grateful_dead.rb similarity index 79% rename from test/faker/movies/test_faker_grateful_dead.rb rename to test/deprecate/unreleased/test_deprecate_faker_grateful_dead.rb index 741e50946a..0ad49b0c1b 100644 --- a/test/faker/movies/test_faker_grateful_dead.rb +++ b/test/deprecate/unreleased/test_deprecate_faker_grateful_dead.rb @@ -2,7 +2,7 @@ require_relative '../../test_helper' -class TestFakerMoviesGratefulDead < Test::Unit::TestCase +class TestDeprecateFakerMoviesGratefulDead < Test::Unit::TestCase def setup @tester = Faker::Movies::GratefulDead end diff --git a/test/faker/music/test_faker_grateful_dead.rb b/test/faker/music/test_faker_grateful_dead.rb new file mode 100644 index 0000000000..f0d6b08f10 --- /dev/null +++ b/test/faker/music/test_faker_grateful_dead.rb @@ -0,0 +1,17 @@ +# frozen_string_literal: true + +require_relative '../../test_helper' + +class TestFakerGratefulDead < Test::Unit::TestCase + def setup + @tester = Faker::Music::GratefulDead + end + + def test_player + assert @tester.player.match(/\w/) + end + + def test_song + assert @tester.song.match(/\w/) + end +end diff --git a/unreleased_README.md b/unreleased_README.md index fa2ea91407..58783f6caf 100644 --- a/unreleased_README.md +++ b/unreleased_README.md @@ -247,7 +247,6 @@ gem 'faker', :git => 'https://github.com/stympy/faker.git', :branch => 'master' - [Faker::Movie](doc/unreleased/movies/movie.md) - [Faker::Movies::BackToTheFuture](doc/unreleased/movies/back_to_the_future.md) - [Faker::Movies::Ghostbusters](doc/unreleased/movies/ghostbusters.md) - - [Faker::Movies::GratefulDead](doc/unreleased/movies/grateful_dead.md) - [Faker::Movies::HarryPotter](doc/unreleased/movies/harry_potter.md) - [Faker::Movies::HitchhikersGuideToTheGalaxy](doc/unreleased/movies/hitchhikers_guide_to_the_galaxy.md) - [Faker::Movies::Hobbit](doc/unreleased/movies/hobbit.md) @@ -259,6 +258,7 @@ gem 'faker', :git => 'https://github.com/stympy/faker.git', :branch => 'master' ### Music - [Faker::Music](doc/unreleased/music/music.md) + - [Faker::Music::GratefulDead](doc/music/grateful_dead.md) - [Faker::Music::Phish](doc/unreleased/music/phish.md) - [Faker::Music::RockBand](doc/unreleased/music/rock_band.md) - [Faker::Music::UmphreysMcgee](doc/unreleased/music/umphreys_mcgee.md)