Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix lint warning and simplify locales test #1430

Merged
merged 1 commit into from Oct 12, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 11, 2022

Fixes this lint warning:

grafik

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Oct 11, 2022
@ST-DDT ST-DDT self-assigned this Oct 11, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner October 11, 2022 18:48
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1430 (7a3136c) into main (f124bfb) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 7a3136c differs from pull request most recent head 9b7fb04. Consider uploading reports for the commit 9b7fb04 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1430   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2166     2166           
  Lines      237450   237450           
  Branches     1041     1045    +4     
=======================================
+ Hits       236550   236568   +18     
+ Misses        879      861   -18     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 88.35% <0.00%> (+4.76%) ⬆️

@ST-DDT ST-DDT changed the title test: fix lint warning and simplify locale test test: fix lint warning and simplify locales test Oct 11, 2022
@Shinigami92
Copy link
Member

let's wait with that one until we merged

@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts s: accepted Accepted feature / Confirmed bug labels Oct 11, 2022
@xDivisionByZerox
Copy link
Member

@ST-DDT Now I see what you wanted to do here. I'm sorry I did not understood at that time...

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 11, 2022

No problem. I sometimes have trouble explaining my ideas/intentions.
If it wasn't for the lint error I wouldn't have proposed it again. Sadly, I didn't notice the lint warning last time.
In v8, I will likely set most warnings to error so that the pipeline fails and I don't have to pay attention anymore.

@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Oct 12, 2022
@ST-DDT ST-DDT force-pushed the test/locales/duplicated-entries2 branch from 551e436 to 9b7fb04 Compare October 12, 2022 10:51
@Shinigami92 Shinigami92 merged commit aee54a1 into main Oct 12, 2022
@ST-DDT ST-DDT deleted the test/locales/duplicated-entries2 branch October 12, 2022 11:21
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants