Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extend vitest with (not) toContainDuplicates #1428

Merged
merged 4 commits into from Oct 12, 2022
Merged

Conversation

Shinigami92
Copy link
Member

Improving some tests with https://vitest.dev/api/#expect-extend

Not sure if there is even a better way instead of importing the ts file all over again

@Shinigami92 Shinigami92 requested a review from a team as a code owner October 11, 2022 17:55
@Shinigami92 Shinigami92 self-assigned this Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1428 (e2fb8c8) into main (8534f86) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
+ Coverage   99.61%   99.62%   +0.01%     
==========================================
  Files        2166     2166              
  Lines      237450   237450              
  Branches     1040     1044       +4     
==========================================
+ Hits       236543   236567      +24     
+ Misses        886      862      -24     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

@ST-DDT ST-DDT changed the title test: extend vitest test: extend vitest with toBeUnique Oct 11, 2022
ST-DDT
ST-DDT previously approved these changes Oct 11, 2022
@ST-DDT ST-DDT requested review from a team October 11, 2022 18:15
@ST-DDT ST-DDT enabled auto-merge (squash) October 11, 2022 18:30
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 11, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Oct 11, 2022
test/vitest-extensions.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 changed the title test: extend vitest with toBeUnique test: extend vitest with (not) toContainDuplicates Oct 12, 2022
@ST-DDT ST-DDT merged commit f124bfb into main Oct 12, 2022
@Shinigami92 Shinigami92 deleted the extend-vitest branch October 12, 2022 10:41
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants