New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: extend vitest with (not) toContainDuplicates #1428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
+ Coverage 99.61% 99.62% +0.01%
==========================================
Files 2166 2166
Lines 237450 237450
Branches 1040 1044 +4
==========================================
+ Hits 236543 236567 +24
+ Misses 886 862 -24
Partials 21 21
|
ST-DDT
previously approved these changes
Oct 11, 2022
ST-DDT
added
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
labels
Oct 11, 2022
ST-DDT
reviewed
Oct 11, 2022
ST-DDT
approved these changes
Oct 12, 2022
Shinigami92
changed the title
test: extend vitest with toBeUnique
test: extend vitest with (not) toContainDuplicates
Oct 12, 2022
xDivisionByZerox
approved these changes
Oct 12, 2022
wael-fadlallah
pushed a commit
to wael-fadlallah/faker
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving some tests with https://vitest.dev/api/#expect-extend
Not sure if there is even a better way instead of importing the ts file all over again