New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(locale): change id_ID name to Indonesian
#1401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1401 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2163 2163
Lines 241303 241303
Branches 1017 1017
=======================================
Hits 240396 240396
Misses 886 886
Partials 21 21
|
fzn0x
changed the title
fix: The citizens of Indonesia should be called
fix(locale): The citizens of Indonesia should be called Sep 27, 2022
Indonesian
Indonesian
import-brain
added
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
labels
Sep 27, 2022
import-brain
approved these changes
Sep 27, 2022
ST-DDT
approved these changes
Sep 27, 2022
Change seems to be correct, but worth to notice, that this is not about citizens of Indonesia, but about locale name. I will update the PR title. |
pkuczynski
changed the title
fix(locale): The citizens of Indonesia should be called
fix(locale): rename id_ID locale to Sep 27, 2022
Indonesian
Indonesian
pkuczynski
changed the title
fix(locale): rename id_ID locale to
fix(locale): rename Sep 27, 2022
Indonesian
id_ID
locale to Indonesian
pkuczynski
approved these changes
Sep 27, 2022
pkuczynski
changed the title
fix(locale): rename
fix(id_ID): change locale name to Sep 27, 2022
id_ID
locale to Indonesian
Indonesian
xDivisionByZerox
approved these changes
Sep 27, 2022
Thanks @pkuczynski ! |
Shinigami92
changed the title
fix(id_ID): change locale name to
fix(locale): change id_ID name to Sep 29, 2022
Indonesian
Indonesian
wael-fadlallah
pushed a commit
to wael-fadlallah/faker
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The citizens of Indonesia should be called
Indonesian
I notice that only Indonesian whos using their country name for calling the citizen that originally from Indonesia, it's should be
Indonesian