Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add first name for zh_CN #1376

Merged
merged 3 commits into from Sep 29, 2022
Merged

feat(locale): add first name for zh_CN #1376

merged 3 commits into from Sep 29, 2022

Conversation

kaysonwu
Copy link
Contributor

add female_first_name and male_first_name for zh_CN

@kaysonwu kaysonwu requested a review from a team as a code owner September 15, 2022 07:28
@kaysonwu kaysonwu closed this Sep 15, 2022
@kaysonwu kaysonwu changed the title add first name for zh_CN chore: add first name for zh_CN Sep 15, 2022
@kaysonwu kaysonwu reopened this Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022 •
edited

Codecov Report

Merging #1376 (4ab4acf) into main (0bbcb7f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files        2163     2165       +2     
  Lines      241306   241432     +126     
  Branches     1017     1021       +4     
==========================================
+ Hits       240399   240549     +150     
+ Misses        886      862      -24     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/zh_CN/name/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/name/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/name/male_first_name.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label Sep 15, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Sep 15, 2022
@Shinigami92
Copy link
Member

Please run pnpm run format once

import-brain
import-brain previously approved these changes Sep 15, 2022
View reviewed changes
@import-brain
Copy link
Member

Names are legit👌

ST-DDT
ST-DDT requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pnpm run format or should we do that for you?

@Shinigami92 Shinigami92 changed the title chore: add first name for zh_CN feat(locale): add first name for zh_CN Sep 29, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) September 29, 2022 15:00
@Shinigami92 Shinigami92 merged commit 1d8ea82 into faker-js:main Sep 29, 2022
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
@kaysonwu @wael-fadlallah
feat(locale): add first name for zh_CN (faker-js#1376)
0889993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain left review comments

Assignees

@kaysonwu kaysonwu

Labels
c: locale Permutes locale definitions
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kaysonwu @Shinigami92 @import-brain @ST-DDT