Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite image module / providers #1350

Closed
ST-DDT opened this issue Sep 6, 2022 · 1 comment · Fixed by #1477
Closed

Rewrite image module / providers #1350

ST-DDT opened this issue Sep 6, 2022 · 1 comment · Fixed by #1477
Assignees
@Shinigami92
Labels
breaking change Cannot be merged when next version is not a major release c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: image Something is referring to the image module p: 1-normal Nothing urgent
Milestone
v8.0 - Module Re-...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Sep 6, 2022

Clear and concise description of the problem

The image module is structured inconsistently and some providers are no longer working or take different parameters.

Suggested solution

  • The image module is restructured
  • Providers/methods that don't work anymore have been removed
  • All "external datasources" are moved to a nested provider with a matching name
  • The method's parameters' defaults have been checked for consistency and usefulness

Alternative

No response

Additional context

No response
@ST-DDT ST-DDT added c: feature Request for new feature s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: image Something is referring to the image module labels Sep 6, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Sep 6, 2022
@ST-DDT ST-DDT mentioned this issue Sep 6, 2022
Closed
@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 6, 2022

Blocked by #932 / #1291

@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Oct 12, 2022
@Shinigami92 Shinigami92 self-assigned this Oct 13, 2022
@Shinigami92 Shinigami92 mentioned this issue Oct 22, 2022
Closed
@Shinigami92 Shinigami92 linked a pull request Oct 22, 2022 that will close this issue
refactor(image)!: rewrite module #1477
Merged
@Shinigami92 Shinigami92 mentioned this issue Oct 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

refactor(image)!: rewrite module faker-js/faker
2 participants
@ST-DDT @Shinigami92