Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): remove SUS names #1303

Merged
merged 2 commits into from Aug 26, 2022
Merged

fix(locale): remove SUS names #1303

merged 2 commits into from Aug 26, 2022

Conversation

bertlobbezoo
Copy link
Contributor

Just removed some questionable names.

@bertlobbezoo bertlobbezoo requested a review from a team as a code owner August 26, 2022 11:52
@Shinigami92 Shinigami92 changed the title chore(locales): remove SUS names fix(locale): remove SUS names Aug 26, 2022
@Shinigami92
Copy link
Member

You need to update the rest snapshot files
Just run the tests and use u

Or ping me if I should do that for you

@ST-DDT ST-DDT added c: bug Something isn't working p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions m: person Something is referring to the person module labels Aug 26, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Aug 26, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 26, 2022 13:37
@Shinigami92 Shinigami92 requested review from a team August 26, 2022 13:37
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1303 (ef9b6aa) into main (9f8f952) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2160     2160              
  Lines      240444   240440       -4     
  Branches     1007     1007              
==========================================
- Hits       239547   239537      -10     
- Misses        876      882       +6     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/en/name/first_name.ts 100.00% <ø> (ø)
src/locales/en/name/last_name.ts 100.00% <ø> (ø)
src/locales/fr_BE/name/last_name.ts 100.00% <ø> (ø)
src/modules/internet/user-agent.ts 82.01% <0.00%> (-1.59%) ⬇️

@bertlobbezoo
Copy link
Contributor Author

Update the tests

@Shinigami92 Shinigami92 merged commit f78843e into faker-js:main Aug 26, 2022
@xDivisionByZerox xDivisionByZerox mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92

Assignees

@bertlobbezoo bertlobbezoo

Labels
c: bug Something isn't working c: locale Permutes locale definitions m: person Something is referring to the person module p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bertlobbezoo @Shinigami92 @ST-DDT