feat(locale): add city names (de) #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheck
changed the title
ST-DDT
added
p: 1-normal
ST-DDT
reviewed
Aug 18, 2022
|
Do you have a source for these (in case we need to need to update it)? |
Codecov Report
@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.01%
==========================================
Files 2159 2159
Lines 240217 240397 +180
Branches 1008 1003 -5
==========================================
+ Hits 239342 239498 +156
- Misses 854 878 +24
Partials 21 21
|
|
Please use the new PR title naming convention: https://github.com/faker-js/faker/blob/main/CONTRIBUTING.md#committing |
atheck
changed the title
|
I took the first 200 cities from here: https://de.wikipedia.org/wiki/Liste_der_Gro%C3%9F-_und_Mittelst%C3%A4dte_in_Deutschland |
Shinigami92
approved these changes
Aug 19, 2022
pkuczynski
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added city names for local
de.