Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetryPolicy & CircuitBreaker #96

Closed
driesva opened this issue Jun 15, 2017 · 4 comments
Closed

RetryPolicy & CircuitBreaker #96

driesva opened this issue Jun 15, 2017 · 4 comments

Comments

@driesva
Copy link

driesva commented Jun 15, 2017

In the documentation there's written:

Execution failures are first retried according to the RetryPolicy, then if the policy is exceeded the failure is recorded by the CircuitBreaker.

But it turns out the retry failures are always recorded by the circuit breaker... When looking at the source code in AbstractExecution::complete it seems to confirm this. Either the documentation is wrong or the code is not behaving correctly.

@celdridge91190
Copy link

I'm having the same issue. My CircuitBreaker is tripping on the first failure attempt, even though my RetryPolicy indicates it should retry. I added logging statements and noticed my Breaker was closed before I even entered my retryOn method.

@jhalterman
Copy link
Member

jhalterman commented Dec 28, 2018

Proper support for composable Policies was merged via 5d919d5. This should be release soon as part of 2.0.

@celdridge91190
Copy link

Do you happen to know when 2.0 is scheduled to be released?

@jhalterman
Copy link
Member

jhalterman commented Dec 28, 2018

@celdridge91190 There are a couple of remaining things I'd like to sort out (see #159 for more info), but probably within a week or two.

The harder work is mostly done, but there are still some design things I'd like to revisit, such as #154 and #160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants