Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java Modules #358

Closed
aalmiray opened this issue Feb 28, 2023 · 1 comment
Closed

Support Java Modules #358

aalmiray opened this issue Feb 28, 2023 · 1 comment

Comments

@aalmiray
Copy link
Contributor

Follow up to #295

v2.4.4 defines an automatic module name

$ jarviz module name --file failsafe-2.4.4.jar 
subject: failsafe-2.4.4.jar
name: net.jodah.failsafe
source: manifest
automatic: true
valid: true

$ jarviz module descriptor --file failsafe-2.4.4.jar 
subject: failsafe-2.4.4.jar
name: net.jodah.failsafe
version: 2.4.4
open: false
automatic: true
requires:
  java.base mandated
contains:
  net.jodah.failsafe
  net.jodah.failsafe.event
  net.jodah.failsafe.function
  net.jodah.failsafe.internal
  net.jodah.failsafe.internal.util
  net.jodah.failsafe.util.concurrent

I'd be great if the library supplied a full Java module descriptor. It's possible to keep bytecode baseline compatible with Java 8 while providing a full module descriptor thanks to ModiTect. This will help modular projects that consume failsafe, specifically those that create custom Java Runtimes with jlink, as the latter does not support automatic modules but explicit modules. If interested I can send a PR to make it happen.

@jhalterman
Copy link
Member

Hi @aalmiray - Thanks for the interest and for filing this. A PR for this would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants