Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle weird attribute inputs #213

Merged
merged 1 commit into from Feb 9, 2021
Merged

Handle weird attribute inputs #213

merged 1 commit into from Feb 9, 2021

Conversation

facelessuser
Copy link
Owner

Fixes #212

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: css-level-2 CSS level 2 selectors. C: css-level-3 CSS level 3 selectors. C: css-matching Related to CSS matching. C: docs Related to documentation. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. labels Feb 9, 2021
@facelessuser facelessuser mentioned this pull request Feb 9, 2021
Closed
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Feb 9, 2021
@facelessuser facelessuser merged commit 0ba6ce8 into master Feb 9, 2021
@facelessuser facelessuser deleted the bugfix/handle-weird-attr-inputs branch February 9, 2021 17:39
jimages
jimages reviewed Feb 11, 2021
View reviewed changes
tests/test_level3/test_not.py
def test_none_inputs(self):
"""Test weird inputs."""

soup = BS('<span foo-"something">text</span>', 'html.parser')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the minus sign intended? or a typo？

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a typo. I had tested the behavior locally, so I'm sure the case works, but this test was a typo. It is now fixed on the main branch and the test works (just for the correct reasons now 🙂).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimages jimages jimages left review comments

Assignees
No one assigned
Labels
C: css-level-2 CSS level 2 selectors. C: css-level-3 CSS level 3 selectors. C: css-matching Related to CSS matching. C: docs Related to documentation. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the :not selector don't work as expected.
3 participants
@facelessuser @jimages @gir-bot