Remove unused variable MODULE #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing this line removes the only reference to `__file__`, which allows tools like pyoxidizer to create standalone binaries that depend on this package. See also: indygreg/PyOxidizer#69
gir-bot
added
S: needs-review
|
Ignore document test failure. I'll look into why that's failing on a pull. |
|
@gir-bot lgtm |
gir-bot
added
S: approved
facelessuser
pushed a commit
that referenced
this pull request
Mar 18, 2020
* Remove unused variable MODULE Removing this line removes the only reference to `__file__`, which allows tools like pyoxidizer to create standalone binaries that depend on this package. See also: indygreg/PyOxidizer#69 * Remove unused os import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
Removing this line removes the only reference to
__file__, whichallows tools like pyoxidizer to create standalone binaries that depend
on this package. See also:
indygreg/PyOxidizer#69