Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test plugin tests on win for forked PR #2212

Merged
merged 1 commit into from May 13, 2022

Conversation

jieru-hu
Copy link
Contributor

@jieru-hu jieru-hu commented May 13, 2022

follow up to https://github.com/facebookresearch/hydra/pull/2207/files
I got the syntax wrong 馃槄

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2022
@jieru-hu
Copy link
Contributor Author

verified plugins tests are run https://app.circleci.com/pipelines/github/facebookresearch/hydra/14451/workflows/77ea98af-c998-4bd4-ae8a-d9e1753b82ca/jobs/141596

@jieru-hu jieru-hu marked this pull request as ready for review May 13, 2022 22:49
@jieru-hu jieru-hu merged commit cee7793 into facebookresearch:main May 13, 2022
@jieru-hu jieru-hu deleted the win_ci branch May 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants