Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable windows tests (except for py3.10) #2210

Merged
merged 5 commits into from May 13, 2022
Merged

re-enable windows tests (except for py3.10) #2210

merged 5 commits into from May 13, 2022

Conversation

jieru-hu
Copy link
Contributor

@jieru-hu jieru-hu commented May 12, 2022

related #2209

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2022
@jieru-hu jieru-hu force-pushed the windows branch 3 times, most recently from 4c15c1b to 5fb7e72 Compare May 12, 2022 22:10
@jieru-hu
Copy link
Contributor Author

not sure why pip does not work in nox for win + py3.10 - I've filed a issue here wntrblm/nox#621

Copy link
Contributor

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow lots of moving parts
thank you

@jieru-hu jieru-hu marked this pull request as ready for review May 13, 2022 21:13
@jieru-hu jieru-hu changed the title windows test re-enable windows tests (except for py3.10) May 13, 2022
@jieru-hu
Copy link
Contributor Author

verified by checking individual circleci job and make sure the tests were run.

@jieru-hu jieru-hu merged commit 4065429 into main May 13, 2022
@jieru-hu jieru-hu deleted the windows branch May 13, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants