Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin tests back #2207

Merged
merged 1 commit into from May 12, 2022
Merged

Add plugin tests back #2207

merged 1 commit into from May 12, 2022

Conversation

jieru-hu
Copy link
Contributor

@jieru-hu jieru-hu commented May 11, 2022 •
edited

closes #2181

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 11, 2022
@jieru-hu jieru-hu marked this pull request as ready for review May 12, 2022 02:01
pixelb
pixelb approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Downside to extra step rather than extra jobs is somewhat slower response from main jobs,
but it's much better having these tests run by default on forked PRs
thanks!

@jieru-hu jieru-hu merged commit 36707bb into facebookresearch:main May 12, 2022
@jieru-hu jieru-hu deleted the ci branch May 12, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelb pixelb pixelb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reinstate non aws plugin testing on forked PRs
3 participants
@jieru-hu @pixelb @facebook-github-bot