remove support for deprecated hydra override syntax #2056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated support for overriding
hydra
config groups without use of the keywordoverride
(see this deprecation notice).Removing this deprecated behavior enables the use of custom subgroups of the top-level hydra config.
Example:
Suppose we have a directory tree like this:
Let's say
my_app.py
is a minimal Hydra app:Before this PR, it is impossible to add
hydra/run: my_run
to the defaults list (sincehydra/run
does not appear in the defaults list ofHydraConf
).This enabled use-case is relevant to discussion #2051.